php-resque-ex icon indicating copy to clipboard operation
php-resque-ex copied to clipboard

Support for Monolog 2

Open boboudreau opened this issue 5 years ago • 6 comments

Monolog 2 removed all non-PSR3 calls including all add*() methods. By using these methods, this library maintains Monolog 1 compatibility, but does not break when using Monolog 2.

boboudreau avatar Sep 10 '19 22:09 boboudreau

Failing tests are because this library still attempts to test against PHP 5.5, and doesn't specify which version of PHPUnit to use in the composer.json file. Not sure if this library is even maintained anymore, but I'd be willing to work with whoever to bring some of the testing up to date if there's desire to do so.

boboudreau avatar Sep 10 '19 22:09 boboudreau

Travis (and the world, really) does not support PHP <= 5.5, so it's probably a good idea to remove that from the travis.yml file, here, too. The rest of the tests pass. I'll let this simmer for a bit and then will update travis.yml if we need a passing PR to make it into master.

boboudreau avatar Sep 10 '19 22:09 boboudreau

See related issue I reported a bit before this PR => https://github.com/wa0x6e/php-resque-ex/issues/53

@wa0x6e are you still active?

mfn avatar Oct 05 '20 06:10 mfn

Let's go ahead and remove php 5.5 from travis, and I'll merge this PR

wa0x6e avatar Oct 05 '20 13:10 wa0x6e

@boboudreau are you still up to finishing this PR? Otherwise I would be available too.

mfn avatar Oct 05 '20 14:10 mfn

Please remove the old php version from travis, so test can pass, and I'll merge it

wa0x6e avatar Oct 05 '20 14:10 wa0x6e