cal-heatmap icon indicating copy to clipboard operation
cal-heatmap copied to clipboard

Add subDomainValueFormat to format values

Open k-nut opened this issue 9 years ago • 3 comments

As proposed in #146 the new subDomainValueFormat lets developers pass their own function that they would like to apply to the number before it is displayed in the popup. This way one can for example make sure that the value is formatted in the proper locale.

Is this the right way to do it? It pretty much just copies the formatDate function. If you think that this is ok I will make sure to write some tests as well.

k-nut avatar May 20 '15 14:05 k-nut

Coverage Status

Coverage decreased (-0.4%) to 77.73% when pulling acca73f8453f9318ddc37114a91fab32a30c2adf on k-nut:add-option-to-format-values into 5b929fc85479592b96b9fca5bd700d058859af08 on kamisama:master.

coveralls avatar May 20 '15 15:05 coveralls

any feedback on this?

k-nut avatar Jul 14 '15 07:07 k-nut

+1 !!

nivhanin avatar Jun 21 '18 08:06 nivhanin