Andrey Rakhmatullin
Andrey Rakhmatullin
Sorry, I've got the wrong commit hash out of the bisect output. Bisect for the provided test case points to af804a53aade42818f5c6ebcee50000e63b0e460. Additionally, bisect for the following test case points to...
TIL pytest has special support for `twisted.trial`
@nicoddemus I think it doesn't work on Twisted 24.7.0 or earlier, or is it expected and having that working is not a goal? ``` ________________________________________________________________________________________________________________ Test.test _________________________________________________________________________________________________________________ '_TracebackFrame' object is...
Yeah, thanks for quick fixes!
As we need to bump Twisted to 20.3.0 when dropping Python 3.8 support, we can do the latter.
@NicoleStrel sure
Oh, that's unexpected. I'm not familiar with the Twisted logging so I don't know the answer. I would prefer not to use `caplog` if `capturedLogs` works with e.g. some changes...
Nice, though I'm not sure about renaming public modules.
Can you please explain which circular import(s) is fixed by this PR?
> The issue stems from some Scrapy files sharing the same names as Python built-in modules, which leads to import conflicts That would explain removing `signal`, but it's no longer...