arduino icon indicating copy to clipboard operation
arduino copied to clipboard

Uncompilable code in power_output_startup()

Open maxgerhardt opened this issue 4 years ago • 2 comments

You write

https://github.com/w600/arduino/blob/b94d129f6d873c3d314ffbe230a236b578a1d186/cores/w600/core_w600_main.cpp#L20-L26

With the only includes being

https://github.com/w600/arduino/blob/b94d129f6d873c3d314ffbe230a236b578a1d186/cores/w600/core_w600_main.cpp#L1-L2

and

https://github.com/w600/arduino/blob/master/cores/w600/debug.h

Yet the function attempts to call into digitalWrite() and and pinMode() which is undeclared.

GCC throws the errors

C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp: In function 'void power_output_startup()':
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp:23:13: error: 'PB_7' was not declared in this scope
     pinMode(PB_7, OUTPUT);
             ^
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp:23:19: error: 'OUTPUT' was not declared in this scope
     pinMode(PB_7, OUTPUT);
                   ^
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp:23:25: error: 'pinMode' was not declared in this scope
     pinMode(PB_7, OUTPUT);
                         ^
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp:24:24: error: 'HIGH' was not declared in this scope
     digitalWrite(PB_7, HIGH);
                        ^
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp:24:28: error: 'digitalWrite' was not declared in this scope
     digitalWrite(PB_7, HIGH);
                            ^

thus the core in its current latest-git form is uncompilable.

Adding #include <Arduino.h> also does not make the code compile because of code in WString.h

Compiling .pio\build\wio_w600\FrameworkArduino\core_w600_main.cpp.o
In file included from C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/Print.h:18:0,
                 from C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/Stream.h:15,
                 from C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/HardwareSerial.h:15,
                 from C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/wiring.h:24,
                 from C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/Arduino.h:13,
                 from C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600\core_w600_main.cpp:21:
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/WString.h:137:83: error: conflicting declaration of C function 'StringSumHelper& operator+(const StringSumHelper&, const char*)'
  friend StringSumHelper & operator + (const StringSumHelper &lhs, const char *cstr);
                                                                                   ^
C:\Users\Maxi\.platformio\packages\framework-arduino-w60x\cores\w600/WString.h:136:27: note: previous declaration 'StringSumHelper& operator+(const StringSumHelper&, const String&)'
  friend StringSumHelper & operator + (const StringSumHelper &lhs, const String &rhs);
                           ^
[...] many more errors

maxgerhardt avatar Sep 24 '20 22:09 maxgerhardt

Hey people of @w600 and @wdyichen, @thingsturn. Is this repository being worked on? No commits for nearly a year but bugs are still open :(

maxgerhardt avatar Oct 15 '20 10:10 maxgerhardt

Seems to be dead.

maxgerhardt avatar Sep 28 '21 17:09 maxgerhardt