Grant-Milestone-Delivery icon indicating copy to clipboard operation
Grant-Milestone-Delivery copied to clipboard

June::Db-milestone_1.md

Open MikeMS-sys opened this issue 3 years ago • 45 comments

Milestone Delivery Checklist

Link to the application pull request: https://github.com/w3f/Grants-Program/pull/466

MikeMS-sys avatar Aug 15 '21 14:08 MikeMS-sys

Thanks for the delivery. We will look into it as soon as possible.

Noc2 avatar Aug 15 '21 14:08 Noc2

Just to link it here. You want to combine this delivery with this amendment, correct? Could you provide more details? Why did you move the current delivery to milestone 4?

Noc2 avatar Aug 17 '21 15:08 Noc2

Hi @Noc2 Yes we want to combine delivery of this Milestone with update of our initial application.

we plan to change 2nd Milestone (hash map data storage) for a new (offchain::ipfs update) and then put hash map data storage in Milestone 4 (the last).

andskur avatar Aug 17 '21 17:08 andskur

The branches/paths linked in Deliverables 0b and 2 don't exist, could you fix those?

semuelle avatar Aug 31 '21 15:08 semuelle

Also:

  • The image on Docker Hub is either private or nonexistent
  • Deliverable 2 points to your own substrate-frontend-template, but the test instructions point to substrate-developer-hub, and I don't see any changes to your fork. Are you still planning on making changes to the frontend? Otherwise creating a fork of your own seems superfluous.
  • Can you add instructions how to build and run locally, with and without Docker, to your testing guide? Following the rs-ipfs instructions, both docker build and cargo build fails with type annotations needed errors.

semuelle avatar Sep 01 '21 11:09 semuelle

@semuelle Hello and sorry for still not answer, unfortunately we were forced to hold the development works for a week for personal reasons beyond our control.

We almost done with updating offchain::ipfs (2nd Milestone). In there are we agreed to coordinate with equilibrium.co updating offchain::ipfs. We have send a mail them, but still didn't got any answer.

And of couse will fix requested changes for Milestone 1.

MikeMS-sys avatar Sep 09 '21 15:09 MikeMS-sys

@MikeMS-sys perhaps try opening an issue or a draft PR on their repo? If you still don't get an answer from them, we'll try to mediate. Happy to hear about your progress. By the way: you'll probably also want to bring the offchain::ipfs Manual up to date as part of the documentation for M2 if needed.

alxs avatar Sep 09 '21 17:09 alxs

@alxs Of course, we were planned it when achive the delivery of the Milestone.

MikeMS-sys avatar Sep 12 '21 10:09 MikeMS-sys

@MikeMS-sys, any updates on this?

semuelle avatar Sep 24 '21 09:09 semuelle

@semuelle To shut down Milestone 1, we had to first update offchain :: ipfs (M2). So, we have already updated [offchain :: ipfs] (https://github.com/rs-ipfs/substrate) and opened a PR on their repo https://github.com/rs-ipfs/substrate/pull/5.

Today we are working on the remaining сlauses of the Grant-milestone-delivery, and then make update for the 1st stage and PR for the 2nd.

Remembering our conversation about the encryption module, we will most likely prepare a PR for 3 Milestone.

MikeMS-sys avatar Sep 24 '21 10:09 MikeMS-sys

Hi @MikeMS-sys, in order to continue with the evaluation of the milestone, could you address the issues I have raised in my two comments above?

semuelle avatar Nov 22 '21 20:11 semuelle

Hi @semuelle! For sure! We plan to make the update at night. Mostly it is not our style to delay the work, but objective reasons contributed to this and we will not keep you waiting long with a justification answer.

MikeMS-sys avatar Nov 29 '21 12:11 MikeMS-sys

@MikeMS-sys

alxs avatar Dec 03 '21 14:12 alxs

@MikeMS-sys any updates on Sebastian's feedback? Please note that the evaluation process is usually a lot faster than it's been the case for these deliveries - according to the terms and conditions, you have 14 days to address feedback. If you can't get back to this within the next 2 weeks, please submit an amendment to update the timeline of your grant and we'll put the delivery on hold.

alxs avatar Jan 17 '22 18:01 alxs

https://github.com/w3f/Grant-Milestone-Delivery/pull/322#issuecomment-1025243528

andskur avatar Jan 30 '22 22:01 andskur

Hi @andskur & @MikeMS-sys. I had planned to evaluate both of your milestones today, but there are still issues with this delivery.

  • There are no public uddug/substrate-juni or andskur/juni-db images on DockerHub as mentioned in 0c and 0d
  • Deliverable 0c is described as "Complex quality assurance for all platform features. Core functions will be fully covered by unit tests to ensure functionality and robustness." The doc only describes how to call functions from the Substrate frontend template, though.

semuelle avatar Mar 10 '22 14:03 semuelle

hi @semuelle , thanks for your reply. Would be very nice if we could evaluate 2nd milestone first. We still need to finish few issues with first milestone delivery (plan to update you about it this weekends)

andskur avatar Mar 10 '22 15:03 andskur

Hey @MikeMS-sys & @andskur, any news on this milestone?

semuelle avatar Apr 04 '22 09:04 semuelle

Hey @MikeMS-sys & @andskur, any news on this milestone?

Hi @semuelle, sorry for late reply. We should figure out last issues (web app and unit testing) and aim to update you later this week or early next week

andskur avatar Apr 06 '22 09:04 andskur

Hi @semuelle, sorry for the long waiting again. We're on the final steps with last issue. Hope to resolve it very soon

andskur avatar Apr 18 '22 06:04 andskur

@andskur sounds good, thanks for the update!

takahser avatar Apr 19 '22 08:04 takahser

Hi! @semuelle @takahser We finally added the requested positions and are waiting for the feedback. Also will make new pr with changes for the next Milestone in the week.

MikeMS-sys avatar May 01 '22 14:05 MikeMS-sys

Hi, sorry for long response - was on holydays. All issues should be already fixed. Will check

andskur avatar May 17 '22 10:05 andskur

ping @andskur

semuelle avatar May 31 '22 09:05 semuelle

Hi, sorry for the long reply. We are relocating our team and business from Russia now. Issues with this delivery should be resolved, i will update you shortly.

andskur avatar Jun 02 '22 07:06 andskur

Hi guys, relocation seen a lot of time and we have just almost finished it. Please give us few more days. A lot of sorry for the delay

andskur avatar Jun 23 '22 09:06 andskur

Hey @andskur, mind sharing your progress with us? Note that given the excessive delays on this grant and since it seems there's been no activity on your repository for the past 2 months, we may terminate it if you don't submit a final delivery within the next 2 weeks. According to our terms and conditions, you have 2 weeks to address defaults from the initial delivery date.

alxs avatar Jul 14 '22 13:07 alxs

Hi @alxs , sorry again for delay. Team relocation spent a lot of our resources. I will provide final delivery soon.

andskur avatar Jul 14 '22 13:07 andskur

Hi guys, I still have to update testing guide. will finish with it a bit later today

andskur avatar Aug 01 '22 14:08 andskur

Hi guys, I still have to update testing guide. will finish with it a bit later today

Hi @andskur, please keep me updated. I've taken over from Sebastian while he's out of office. Thanks!

ashlink11 avatar Aug 12 '22 21:08 ashlink11