webrtc-stats icon indicating copy to clipboard operation
webrtc-stats copied to clipboard

Sender-side packetsReceived can be negative from garbage RRs

Open jan-ivar opened this issue 1 year ago • 1 comments

Sender-side packetsReceived is unsigned, yet is a result of a subtraction of two RR values that could be garbage:

image

Having stats reflect garbage input seems helpful for debugging, but it's unspecified what value user agents should report if the result of the subtraction is negative. Changing it to signed seems simplest, and would match packetsLost.

This came up in bug 1853717 which (ended up being a bug in Firefox instead but) raised how to handle garbage RRs from a server.

jan-ivar avatar Nov 07 '23 19:11 jan-ivar

Having it be signed instead makes sense to be

henbos avatar Nov 08 '23 11:11 henbos