webrtc-stats icon indicating copy to clipboard operation
webrtc-stats copied to clipboard

add framesDropped stats to video sender(RTCOutboundRtpStreamStats)

Open bdrtc opened this issue 2 years ago • 4 comments

video frame maybe dropped prior to encode, according to webrtc code the capture video frame maybe dropped by encoder's internal rate limiter or MediaOptimizations , but no stats about this now, its useful for diagnose online video problems, and the same stats exist in[RTCInboundRtpStreamStats. we recommend add such stats to video sender side.

bdrtc avatar Oct 09 '22 03:10 bdrtc

we add this in native code, add get via getStas, report to our diagnostic system for analize online user rtc problem.

lidp888 avatar Oct 17 '22 02:10 lidp888

I think you can look at the delta between media-source.frames and outbound-rtp.framesEncoded

henbos avatar Oct 18 '22 13:10 henbos

inputFrames and framesEncoded should give you this.

vr000m avatar Oct 18 '22 13:10 vr000m

yes, user can calculate this via exist stats, but it leave complex to end user, the same stats exist in RTCInboundRtpStreamStats, but not exist in RTCOutboundRtpStreamStats, user may confused.

bdrtc avatar Oct 19 '22 03:10 bdrtc

framesDiscardedBeforeSend is that the metric that you need? in this case, we should put it in to provisional-stats, unless this is going to be exposed by the browsers.

vr000m avatar Oct 26 '22 15:10 vr000m

libwebrtc has 185 implemented metrics (or 213 if you include some deprecated ones; 232 if you also include some that are not exposed to JavaScript). So as much as I like convenience, I'm opposed to adding metrics that are equivalent to "X - Y" of already exposed metrics.

henbos avatar Oct 27 '22 07:10 henbos

framesDiscardedBeforeSend is that the metric that you need? in this case, we should put it in to provisional-stats, unless this is going to be exposed by the browsers.

not necessary,user want get it via getStats and report to a diagnostic system, we can get it via what @henbos described.

bdrtc avatar Oct 27 '22 08:10 bdrtc

👍

henbos avatar Oct 27 '22 08:10 henbos