webrtc-pc icon indicating copy to clipboard operation
webrtc-pc copied to clipboard

Stopping senders and receivers: Present or absent?

Open alvestrand opened this issue 4 years ago • 2 comments

The current spec says (https://w3c.github.io/webrtc-pc/#dfn-collectsenders):

For each transceiver in transceivers, If transceiver.[[Stopped]] is false add transceiver.[[Sender]] to senders.

I don't know if this was written before or after [[Stopping]] was introduced, but I'd like to be sure we really intended to show senders and receivers of transceivers in the "stopping, not stopped" state.

alvestrand avatar Sep 23 '20 10:09 alvestrand

For reference, [[Stopping]] was introduced in 40719f46665005ae5b819110ff1731492bca6f6f (June 2019), where as that piece of the algorithm was introduced in 85284b76baebf9e149d194e692be16a21768a91a (August 2018)

dontcallmedom avatar Sep 23 '20 13:09 dontcallmedom

getSenders and getReceivers should return any sender or receiver in the set of transciever. The "if stopped" language is superflous and can be removed, but it is working as intended.

For a PR: Remove the superflous language. Also when setting an answer, instead of saying "If transceiver is stopped, associated with an m= section and the associated m= section is rejected in connection.[[CurrentLocalDescription]] or connection.[[CurrentRemoteDescription]], remove the transceiver from the connection's set of transceivers." I think we should simply say "If transceiver is stopped, remove the transceiver from the connection's set of transceivers."

henbos avatar Sep 24 '20 14:09 henbos