webauthn icon indicating copy to clipboard operation
webauthn copied to clipboard

Namespace authData dfns under authData/ and flags under authData/flags/

Open emlun opened this issue 2 years ago • 1 comments

This is a step towards resolving #1740 and #1510, but I think it's substantive enough to warrant review on its own. This is a prerequisite of PR #1772, PR #1773 and PR #1774.

This repurposes the definitions of the UP and UV terms from referring to the abstract procedure to the corresponding authenticator data flags instead, because we were already using the terms only to refer to the flags. Also added are formal definitions for the other authData flags. These definitions along with those for other authData components are also moved into the authData/ namespace for better consistency with properties of other interfaces and dictionaries.

This will break some link anchors:

Anchor before Anchor after
#rpidhash #authdata-rpidhash
#flags #authdata-flags
#signcount #authdata-signcount
#attestedcredentialdata #authdata-attestedcredentialdata
#authdataextensions #authdata-extensions
#up #authdata-flags-up
#uv #authdata-flags-uv
#aaguid #authdata-attestedcredentialdata-aaguid
#credentialidlength #authdata-attestedcredentialdata-credentialidlength
#credentialid #authdata-attestedcredentialdata-credentialid
#credentialpublickey #authdata-attestedcredentialdata-credentialpublickey

Preview | Diff

emlun avatar Jul 11 '22 14:07 emlun

PR #1663 adds a non-autolink reference to #aaguid which will need to be updated if this gets merged.

emlun avatar Jul 26 '22 16:07 emlun

I missed the last meeting, but judging by the meeting minutes it seems @agl approves of merging this. I think that makes enough approvals, so I intend to go ahead and merge this after 2022-08-18T12:00 UTC. Please raise any objections before then (a simple "please wait" is enough).

emlun avatar Aug 16 '22 12:08 emlun