wai-tutorials
wai-tutorials copied to clipboard
Update multi-level.md
The actual HTML that's used on this page doesn't follow the page's own advice about using td
elements (rather than th
elements) when the cell is empty.
This pull request updates that code so it's consistent with the code snippet
Deploy Preview for wai-tutorials2 ready!
Name | Link |
---|---|
Latest commit | e7ae6043c8a47d4cb1c94e40fa1eaeb40ada5d38 |
Latest deploy log | https://app.netlify.com/sites/wai-tutorials2/deploys/65168a07bbca6d000870f92a |
Deploy Preview | https://deploy-preview-726--wai-tutorials2.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
More investigation/work is needed here because once the element is changed to a <td>
we lose the background colour. Design-wise it would be good to keep that colour for the header rows/columns even if blank.
Thanks, good catch, @brianelton.
That said, just for reference, on other pages on the production site, like https://www.w3.org/WAI/tutorials/tables/two-headers/, td
's are being used in a similar way to how it's used in this pull request. For example:
If it's important to keep the styling of the th
in this pull request, one idea could be to create a .th
class, that could be added to the td
element, like:
th, .th {
font-weight: 700;
color: #fff;
color: var(--pure-white);
background-color: #005a6a;
background-color: var(--wai-green);
}
What do you think?
Thanks, Ed
Actually, thanks for pointing that out. simply using the <td>
without any change to styling matches the other instances. This is fine as is.
The PR is approved and I will merge it along with other PRs soon.
@shawna-slh this is ready to merge.