wai-tutorials icon indicating copy to clipboard operation
wai-tutorials copied to clipboard

Fly out menu example on WAI tutorials seems to use aria-haspopup which may not be optimal

Open mraccess77 opened this issue 3 years ago • 3 comments

The flyout controls page indicates haspopup should be used to indicate menus - but this structure is not a menu. Also in ARIA 1.2 haspopup is being deprecated as a global attribute and will only be usable on certain controls. I would recommend the pattern be updated to follow the ARIA authoring practices example: Current Flyout: https://www.w3.org/WAI/tutorials/menus/flyout/ Recommended ARIA practices approach: https://w3c.github.io/aria-practices/examples/disclosure/disclosure-navigation.html

mraccess77 avatar Feb 02 '21 17:02 mraccess77

I think it is sufficient to remove the aria-haspopup. The rest of the example can stay as it is. The use of links instead of buttons makes more sense in a navigation

JAWS-test avatar Feb 03 '21 04:02 JAWS-test

Version 2.0 of the page (integrating it into the current WAI design and fixing the most outrageous bugs), which was completed over 11 months ago, also still has aria-haspopup: https://wai-tutorials.netlify.app/tutorials/menus/flyout/

I agree that it can be completely removed.

yatil avatar Feb 09 '21 12:02 yatil

Duplicate of #611.

yatil avatar Feb 09 '21 13:02 yatil

aria-haspopup removed in PR #633

brianelton avatar Sep 02 '22 18:09 brianelton