trusted-types icon indicating copy to clipboard operation
trusted-types copied to clipboard

Add missing parameter name for algorithm

Open TimvdLippe opened this issue 8 months ago • 1 comments

It currently lists all parameters explicitly, except for input. While implementing this algorithm in Servo, I was confused what the value of input is supposed to be. Then I saw that it is probably the third argument, so let's make that explicit.


Preview | Diff

TimvdLippe avatar Apr 13 '25 09:04 TimvdLippe

I have linked my GitHub acccount to a W3C account

TimvdLippe avatar Apr 13 '25 09:04 TimvdLippe

@fred-wang do you mind restarting this build? Seems like a tiny fix

TimvdLippe avatar Jul 03 '25 08:07 TimvdLippe

@TimvdLippe mmh, I don't know how I can do that (maybe @lukewarlow knows?). Shouldn't a forced push do that automatically?

fred-wang avatar Jul 03 '25 08:07 fred-wang

I made this change via the GitHub UI and don't have a local copy available that I can run git commands on :/ I could recreate the PR?

TimvdLippe avatar Jul 03 '25 08:07 TimvdLippe

Sorry I don't think I can relaunch the ipr check

fred-wang avatar Jul 03 '25 08:07 fred-wang

I'm going to go ahead and mark this as non substantative because that's what it is

lukewarlow avatar Jul 03 '25 09:07 lukewarlow

lukewarlow marked as non substantive for IPR from ash-nazg.

w3cbot avatar Jul 03 '25 09:07 w3cbot

Cool thanks for figuring it out!

TimvdLippe avatar Jul 03 '25 10:07 TimvdLippe