respec icon indicating copy to clipboard operation
respec copied to clipboard

ARIA specs broken - definitionMap not defined

Open jnurthen opened this issue 5 years ago • 3 comments

Important info

  • URL to affected spec: https://w3c.github.io/aria/
  • ReSpec version: 25.6.0
  • [x] I did a "hard refresh", but it's still busted.

Description of problem

ARIA (and a number of specs) have shared terms. We clean these up by removing any which are not referenced in https://github.com/w3c/aria-common/blob/master/script/resolveReferences.js which includes the following where it attempts to remove references from respec

                $p.getDfnTitles().forEach(function( item ) {
                    if (respecConfig.definitionMap[item]) {
                        delete respecConfig.definitionMap[item];
                    }
                });

This no longer works

This worked when we published in December so my guess is that this is caused by https://github.com/w3c/respec/pull/2682

Can you help us get this working again. I don't mind making minor code changes to get it working.

jnurthen avatar Apr 17 '20 20:04 jnurthen

https://github.com/w3c/aria-common/issues/98

jnurthen avatar Apr 17 '20 20:04 jnurthen

That's indeed a regression. We recently stopped supporting the w3c-common profile, but I'll get the fix for this bug in.

Alternatively, if you could explain what exactly resolveReferences.js does, we might be able to integrate it in ReSpec. I've seen similar thing being used in json-ld specs if I'm not wrong.

@saschanaz I'm thinking of creating a side-channel for updates to w3c-common profile. We won't actively support it, but may add fixes for severe regressions. My plan is to branch off v25.5.0, build manually when needed (should be rare) and copy builds to /builds folder when we release.

The bug here is, we copied over definitionMap instead of referencing it in to respecConfig. Also, definitionMap as key in respecConfig got lost. https://github.com/w3c/respec/blob/45a4d300c3bbe30f2a81d7b9a978d837a3494458/src/w3c/defaults.js#L55

sidvishnoi avatar Apr 17 '20 21:04 sidvishnoi

Sounds good, we should still maintain it even when we don't add features.

saschanaz avatar Apr 17 '20 21:04 saschanaz