epubcheck icon indicating copy to clipboard operation
epubcheck copied to clipboard

CLI epubcheck checking more than one file at a time

Open shlomif opened this issue 4 years ago • 4 comments

In https://github.com/shlomif/epubcheck/compare/master..feature-branch--multiple-files-on-cmd-line I started implementing checking multiple filenames, e.g:

java -jar ~/Download/unpack/to-del/epubcheck/target/epubcheck.jar  $(find -name '*.epub' | sort) |& tee ~/epubcheck.txt 

I still need to document it and add automated tests, but is this feature considered desirable?

(Thanks for epubcheck, btw!)

shlomif avatar Mar 20 '21 15:03 shlomif

Hi @shlomif. Thanks for proposal, nice!

In fact I'll soon publish a pull request for revamping the CLI. Maybe that feature can be added there instead of on the current code… I'll comment to this thread when there's something to review, and I will also have a look at your fork in the meantime!

rdeltour avatar Mar 29 '21 11:03 rdeltour

Hi @rdeltour !

Hi @shlomif. Thanks for proposal, nice!

I'm glad you approve.

In fact I'll soon publish a pull request for revamping the CLI. Maybe that feature can be added there instead of on the current code… I'll comment to this thread when there's something to review, and I will also have a look at your fork in the meantime!

Thanks! The implementation there is still quite hacky AFAIR, and one should also add tests. Note that dealing with java/maven/jdk on epubcheck was fairly straightforward and epubcheck helped modernise and correct rebookmaker ( https://pypi.org/project/rebookmaker/ ). Great job!

shlomif avatar Mar 30 '21 14:03 shlomif

@rdeltour : hi! was the pull-req published? can you give a link?

shlomif avatar Oct 24 '21 05:10 shlomif