did-core icon indicating copy to clipboard operation
did-core copied to clipboard

Use `publicKeyMultibase` instead of `publicKeyBase58` field in all examples

Open Patrik-Stas opened this issue 1 year ago • 7 comments

Hi, I believe that some examples were by mistake using publicKeyBase58 rather than publicKeyMultibase - I've updated the examples. Let me know if I am missing something.

Cheers


Preview | Diff

Patrik-Stas avatar Mar 21 '24 00:03 Patrik-Stas

The examples use Ed25519VerificationKey2018, which only supported publicKeyBase58. We do plan to update the examples to use more modern key formats such as Multikey, which does use publicKeyMultibase.

msporny avatar Jul 07 '24 19:07 msporny

@Patrik-Stas could you please update the PR to use Multikey, you can find the format description here:

https://w3c.github.io/controller-document/#multikey

msporny avatar Jul 07 '24 19:07 msporny

Related to the context discussion on today's call. Suggestion is to pull in the new multikey context.

decentralgabe avatar Aug 15 '24 15:08 decentralgabe

iherman marked as non substantive for IPR from ash-nazg.

w3cbot avatar Aug 15 '24 15:08 w3cbot

This was discussed during the WG meeting on 2024-08-22: https://www.w3.org/2024/08/22-did-minutes.html#t06

pchampin avatar Aug 26 '24 09:08 pchampin

Since we haven't heard back from the original author yet, I'll effect these changes on the core specification.

msporny avatar Sep 19 '24 15:09 msporny

This was discussed during the #did meeting on 19 September 2024.

View the transcript

w3c/did-core#852

manu: This one is waiting on merge conflict resolution
… We might have to do a more complete fix with this one. Or pull the PR in and make the fix later

decentralgabe: I noticed you tagged the author. If manu you can take it over that would be great

manu: Sure, I can take it over.

ivan: Why do you think it is aclass 2 change? I think it is a class 3
… using public key multibase effects implementations

manu: It effects the examples, this is non-normative

ivan: Okay, yep its a class 2

manu: There is a separate issue that discusses upgrading to publicKeyMultibase

https://github.com/w3c/did-core/issues


pchampin avatar Sep 19 '24 15:09 pchampin

This PR has been merged into PR #867. Closing.

msporny avatar Oct 30 '24 17:10 msporny