core-aam icon indicating copy to clipboard operation
core-aam copied to clipboard

MSAA+IA2 mapping clean up (subscript, superscript, definition and paragraph)

Open spectranaut opened this issue 1 year ago • 4 comments

In the spec, the MSAA mapping is:

In the WPT core-aam test, the MSAA mapping is:

spectranaut avatar Jul 11 '22 21:07 spectranaut

The original mappings in HTML AAM were ROLE_SYSTEM_TEXT and IA2_ROLE_TEXT_FRAME for MSAA/IA2.

other newer roles for text-level semantic elements also have ROLE_SYSTEM_GROUPING... if they even list the MSAA role at all. for instance code only lists IA2_ROLE_TEXT_FRAME

scottaohara avatar Jul 11 '22 21:07 scottaohara

I commented on the pull request. But I think the test needs to be updated.

See:

  • https://github.com/w3c/core-aam/issues/55
  • https://source.chromium.org/chromium/chromium/src/+/main:ui/accessibility/platform/ax_platform_node_win.cc;l=6557

joanmarie avatar Jul 12 '22 11:07 joanmarie

thanks @joanmarie, and apologies @spectranaut - my comment was not to indicate that I thought the mapping should change back, but was more to note what the mappings previously were and mention that they, along with some other new text-level roles, were also mapping to ROLE_SYSTEM_GROUPING - e.g., mark.

Looking through these text-level roles in more detail this morning, at first glance it does seem odd that some of them map to grouping while others have text mappings (e.g., strong) - though I'm assuming this was done to promote the semantic importance of some types of text (sub/sup/mark...) - at least, I make that connection per James Teh's comment in the linked thread.

So, with that said i think I do agree that the tests need updating, not core aam.

Though in looking through what core aam has for some other roles (definition and paragraph) it does seem that core aam isn't aligned with what's implemented in chromium. Both of these return ROLE_SYSTEM_GROUPING in the chromium code, but definition only has Object Attribute: xml-roles:definition and paragraph says Role: ROLE_SYSTEM_TEXT In core aam

scottaohara avatar Jul 12 '22 12:07 scottaohara

PR on wpt for subscript/superscript: https://github.com/web-platform-tests/wpt/pull/34814

I'm going to rename this issue more generally and look into the things you brought up with definition and paragraph later, @scottaohara !

spectranaut avatar Jul 12 '22 17:07 spectranaut