compute-pressure icon indicating copy to clipboard operation
compute-pressure copied to clipboard
verified publisher icon w3c

Wide review tracker

Open anssiko opened this issue 2 years ago • 20 comments

About

This is a meta issue to track wide review for the Compute Pressure API.

An important part of wide review is horizontal review from W3C's key horizontal groups listed below in horizontal groups section. Also feedback from other stakeholders is equally important. Additional pointers are welcome via comments.

The list is based on the How to do wide review page guidance.

Legend: 🔴 Review request not submitted 🟡 Review request submitted 🔵 Review feedback received 🟢 Review closed as completed

Horizontal groups

🟢 ♿ Accessibility

🟢 📐 Architecture

  • [x] Ask the TAG for review; see how to work with the TAG

    • [x] https://github.com/w3ctag/design-reviews/issues/795
    • [x] Positive feedback received on data minimization approach: https://github.com/w3ctag/design-reviews/issues/795#issuecomment-1513997968

  • [x] If you are developing javascript APIs you may also want to ask [email protected], a technical discussion list shared by W3C and ECMA's TC 39

    • [x] No issues related to JS language features that should be brought to TC 39 for consideration.

🟢 🌍 Internationalisation

🟢 🔍 Privacy

🟢 🔒 Security

Other stakeholders

From who to ask for review:

Horizontal reviews [...] are only a subset of a full wide review, which must also include other stakeholders including Web developers, technology providers and implementers not active in the Working Group, external groups and standards organizations working on related areas, etc.

🟢 Zoom - positive signals and support https://github.com/w3c/compute-pressure/issues/14

anssiko avatar Jan 30 '23 18:01 anssiko

I have now initiated the Privacy and Security reviews with the respective horizontal groups.

In addition, I have staged both the Accessibility and Internationalisation reviews for submission, pending editors' review of the checklist materials to be provided as references in these requests.

Lastly, we had submitted the Architecture (aka TAG) review request earlier.

The status of our overall wide review progress is being tracked in this issue with links to the relevant material and feedback. Our goals is to turn all 🔴 into 🟡 during Q1, and push to 🟢 during Q2.

Your diligent efforts ensure that the entire set of stakeholders of the web community, including the general public, have had adequate notice of the progress of the Working Group and are able to actually perform reviews of and provide comments on the specification.

Our second objective is to make sure we request reviews early enough that comments and suggested changes can still be reasonably incorporated in response to the review.

Thank you for your contributions.

anssiko avatar Feb 07 '23 09:02 anssiko

Current status:

  • All wide review requests have been submitted.

  • Internationalisation review has been completed.

  • Privacy review feedback has been received and is being addressed.

Please refer to the tracker in the first comment for pointers.

anssiko avatar Mar 29 '23 18:03 anssiko

Current status:

  • Accessibility review request queued for processing.

  • Architecture review received. Positive feedback with a request to share developer feedback when available. Confirming if further feedback is expected.

  • Privacy review feedback broken into privacy-needs-resolution issues welcomes contributions.

  • Security review closed as completed.

anssiko avatar Apr 24 '23 13:04 anssiko

Current status:

  • Accessibility reviewers volunteered to contribute an Accessibility considerations section to the spec in https://github.com/w3c/a11y-request/issues/53#issuecomment-1533760944 (thanks @matatk et al.!), the WG expect this contribution by the end of this month.

  • Architecture review received. Positive feedback with a request to share developer feedback when available. No new information since the Apr 24 status update.

  • Privacy review feedback improved the Security and Privacy considerations substantively (thanks @pes10k!) in #216, remaining improvements under review in #218 and #219

  • Security review closed as completed.

anssiko avatar Jun 05 '23 12:06 anssiko

I'm thrilled to announce wide review for the Compute Pressure API has been completed. 🥳

The Devices and Sensors Working Group would like to thank numerous contributors across Accessibility, Architecture, Internationalization, Privacy and Security horizontals for their deligent review and contributions.

anssiko avatar Dec 13 '23 17:12 anssiko

@anssiko Next step toward CR after HR, would be settling down all spec issues (or marking related part as at-risk?), and call for consensus to publish as CR within the group, I believe. It seems there is only small number of registered issues (except for V2 or enhancement), we may go further shortly. How do you think? (of course, all works might start after new year.)

himorin avatar Dec 19 '23 05:12 himorin

@himorin, thanks for reminding us of the next Rec Track transition ahead of us.

I'd like to share with the WG that a number of high-profile customers want to continue experiment with the API. To that end, we announced an intent to extend the Chrome Origin Trial from 120 to 123 inclusive, running until early April '24. The goal of this extension is to gather feedback to further increase the WG's confidence we are addressing real user needs across a variety of use cases.

I believe the WG wants to integrate the feedback from these early adopters before advancing to a CR, so I'd suggest we check back when we have completed the Origin Trial extension. It is definitely great to see the wide review (one of the important requirements for advancing to a CR) completed with major contributions to the specification.

anssiko avatar Dec 19 '23 14:12 anssiko

Feedback from early adopters of the Compute Pressure API is now available: https://github.com/w3ctag/design-reviews/issues/795#issuecomment-1982796332

This feedback suggests the current version of the API is addressing real customer needs. The feedback also motivates possible future work.

@kenchris @arskama please ensure that we have recorded the relevant feedback for possible future work as GH issues in this repo, labeled as https://github.com/w3c/compute-pressure/labels/V2

anssiko avatar Mar 07 '24 07:03 anssiko

The Compute Pressure API shipped in Chrome 125 Stable release yesterday. Congratulations everyone who made this happen!

This important implementation milestone was reached after an extensive trial period with real-world customers between July 2023 and March 2024. Feedback received during this trial period demonstrated the API addresses important end user needs and motivated the shipping decision.

Considering this significant advancement on the implementation front, I recommend the WG to start advancing this specification toward the Candidate Recommendation stage in the near future. This transition is to formally signal the specification is welcoming further implementation experience.

We will assess the CR transition readiness in the coming months with assistance from @himorin and will follow up with more information and concrete next steps. Meanwhile, I encourage the editors @kenchris @arskama to triage the remaining open issues and label any issues considered out of scope for the expected CR, including any new features, as https://github.com/w3c/compute-pressure/labels/V2 This is to help delineate what should be addressed by CR from what comes after.

anssiko avatar May 15 '24 14:05 anssiko

Thats wonderful @anssiko . I'm repeating myself I know, but i just wanted to appreciate your group for working so hard and collaboratively to address the privacy risks that PING identified, and integrating mitigations into the default behavior in the spec so that Web users and sites can benefit from this new, exciting functionality without putting users at risk. Congratulations to you all again

pes10k avatar May 15 '24 15:05 pes10k

Working on this specification together with you @pes10k and the PING participants has been a rewarding experience for the entire group. Your major contributions shaped what became an extensive security and privacy considerations section documenting both identified threats and innovative mitigation strategies, also incorporated into normative definitions.

Our group is guided by our mission statement ("create secure and privacy-preserving client-side APIs") so your kind words mean a lot to us. Your feedback tells us we're doing the right things and doing them right.

I'm proud to see this API ship with the strong privacy protections we co-designed. Thank you for co-traveling with us on this journey.

anssiko avatar May 15 '24 16:05 anssiko

@kenchris @arskama in preparation for our TPAC discussion https://github.com/w3c/devicesensors-wg/issues/69, can you please triage the remaining open issues and:

  • label any open issues considered out of scope for the expected CR, including any new features, as https://github.com/w3c/compute-pressure/labels/V2
  • and then, identify issues out of the remaining issues that are not V2 that are substantive bug fixes to be addressed prior CR, and label them as https://github.com/w3c/compute-pressure/labels/bug

You can also use other labels as appropriate, but check the assignment for those two (V2, bug) are up to date.

This will help the group make an informed decision on the publication readiness. Thank you!

anssiko avatar Sep 12 '24 13:09 anssiko

https://github.com/w3c/compute-pressure/labels/V2 labels:

  1. v2 labels under investigation, higher prirority, or requires discussions:
  • #8 : Working on a solution, requires some discussion with isv's and chromium team.
  • #233: Buffering of CP statuses before requesting: Subject to discussion
  • v2 labels out of current scope:
    • #9 Specification wise easy, but implentation is complex. no OS APIs or paltform API available.
    • #119: No investigation on metrics and algorithm.
    • #120: Requires discussion on possible usage, metrics and memory types, platform and OS API available. wide area of research.
    • #228: Catch-All pressure: Not feasible at the moment, very complex to define.
    • #246: Not investigated.
    • #249: Not invetigated.
    • #288: Not investigated.

    https://github.com/w3c/compute-pressure/labels/bug labels:

    1. #243: No easy fix before CR.
    2. #281: Could be fixed before CR.
    3. #291: Could be fixed before CR.

    arskama avatar Sep 18 '24 06:09 arskama

    Thanks @arskama. If there are bugs that you think should be out of scope for CR, you could use a combination of https://github.com/w3c/compute-pressure/labels/bug + https://github.com/w3c/compute-pressure/labels/V2 for those.

    anssiko avatar Sep 18 '24 06:09 anssiko

    also I believe 'no', but is there any (additional) at-risk feature we should mark?

    himorin avatar Sep 18 '24 09:09 himorin

    @himorin I believe thermals pressure source could be marked as at risk.

    anssiko avatar Sep 18 '24 13:09 anssiko

    Current status:

    • The only at risk feature identified has been removed in https://github.com/w3c/compute-pressure/pull/300
    • The only remaining https://github.com/w3c/compute-pressure/labels/bug https://github.com/w3c/compute-pressure/issues/243 has a PR #303 in review.
    • The rest of the open issues are either deferrer to https://github.com/w3c/compute-pressure/labels/V2 or considered non-blocking for CR based on our TPAC discussion.

    @himorin I plan to initiate a CfC to publish the CR when PR #303 has landed. Please let us know if you identify any further areas that require attention prior to the expected publication.

    anssiko avatar Nov 22 '24 08:11 anssiko

    CfC to publish Compute Pressure API Candidate Recommendation Snapshot - review by 29 Nov 2024

    anssiko avatar Nov 22 '24 11:11 anssiko

    To summarize the improvements made in response to the wide review and Origin Trial feedback, please see all the changes since this wide review was initiated:

    • HTML diff since 2023-02-03 until the latest
    • commits since 2023-02-03 until 2024-12-05

    These changes were made to:

    • satisfy wide review feedback as documented and referenced in this issue (initiated 2023-02-07 completed 2023-12-13)
    • address feedback from the Origin Trial in Chrome 115 to 123 (started 2023-07-20 ended 2024-04-02)
    • improve specification clarity informed by implementation experience

    The API shipped in Chrome 125 on 2024-05-28.

    Looking at the timelines, we observe both the wide review and Origin Trial were partially run in parallel. To ensure specification stability during this overlapping period, while the Origin Trial was active only a small number minor changes not attributable to the wide review feedback were made to the specification, see commits since 2023-07-20 until 2024-04-02. Based on my assessment, the changes during this period do not warrant re-review.

    @kenchris please let @himorin know of any substantial changes since 2023-02-03 until 2024-12-05 that might benefit from re-review. Considering changes during OT were minimized, I'd focus on commits since 2024-04-02 until 2024-12-05. Changes that have no user or script-visible impact are usually out of scope for such re-reviews, while any new features would be of interest. Please also review PR https://github.com/w3c/compute-pressure/pull/306 that documents substantive changes since the First Public Working Draft publication 2022-12-20. Your contributions will help advance with the CR transition request https://github.com/w3c/transitions/issues/681.

    anssiko avatar Dec 05 '24 09:12 anssiko

    We made a few renames, but they don't warrant re-review, and our privacy fixes have been carefully reviewed and approved by the PING. We added an accessibility section, but that was also discussed and contiributed by the APA WG.

    kenchris avatar Dec 05 '24 10:12 kenchris

    Compute Pressure API Candidate Recommendation Snapshot was published today, see the announcement. 🥳

    To that end, I'm closing this wide review tracker. Thank you to all the folks who contributed their diverse expertise to this API through wide review!

    anssiko avatar Apr 24 '25 08:04 anssiko