bp-i18n-specdev icon indicating copy to clipboard operation
bp-i18n-specdev copied to clipboard

Add dark mode support

Open xfq opened this issue 1 year ago • 5 comments

Fix #129.


Toggle dark mode in your system to see the effect:


Preview | Diff

xfq avatar Mar 14 '24 03:03 xfq

Deploy Preview for bp-i18n-specdev ready!

Name Link
Latest commit ecc58e48cf4df258b346f395364e3506cb43e7a9
Latest deploy log https://app.netlify.com/sites/bp-i18n-specdev/deploys/663858bb7ccd4c00086ab501
Deploy Preview https://deploy-preview-130--bp-i18n-specdev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 14 '24 03:03 netlify[bot]

Do we have a plan to port to all specs?

Yes. As mentioned in #129, if it's good enough, we can make our other documents (LTLI, counter styles, string-meta, string-search, timezone, lreq, and so on) support it too.

This PR is not ready to merge yet, I still need to double check all the colors before merging.

xfq avatar Mar 20 '24 06:03 xfq

I updated some colours and removed some styles that were no longer useful.

Ready for review/merge now.

xfq avatar Mar 22 '24 06:03 xfq

Filed https://github.com/w3c/respec/issues/4687

After merging this PR, I'll look into updating https://www.w3.org/International/i18n-activity/guidelines/editing#localcss

xfq avatar Mar 22 '24 07:03 xfq

I think local.css needs to be updated to support @media (prefers-color-scheme: dark) for those <aside class="links">. That's not under ReSpec's control.

marcoscaceres avatar Apr 12 '24 05:04 marcoscaceres