aria
aria copied to clipboard
PDF-AAM initial HTML tables import
Closes https://github.com/w3c/pdf-aam/issues/7
This PR consists of the initial import of the HTML tables for the PDF-AAM mappings. My understanding is with this PR we will officially have our first public working draft of the PDF-AAM.
I am unsure what, if any, tests need to be run for this PR. I expect at this stage most, or all, of these tests do not need to be run, please correct me if that assumption is incorrect.
- [ ] "author MUST" tests:
- [ ] "user agent MUST" tests:
- [ ] Browser implementations (link to issue or commit):
- WebKit:
- Gecko:
- Blink:
- [ ] Does this need AT implementations?
- [ ] Related APG Issue/PR:
- [ ] MDN Issue/PR:
Deploy Preview for wai-aria ready!
| Name | Link |
|---|---|
| Latest commit | a0db9f2c0b3a75c4126b26007492ee22ebc17bce |
| Latest deploy log | https://app.netlify.com/projects/wai-aria/deploys/68caecea723cf40008c65bc0 |
| Deploy Preview | https://deploy-preview-2466--wai-aria.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Hi Zak! A few things to get this landed:
- Remove 3 references to CSS files, these files no longer exist (a change that just landed recently)
- We are now using the respec
class="data"on all the mapping tables, so you will want to add that to all of the pdf-aam mapping tables.- When there is a wai-aria analygous role, and the mapping should be the same, rather than repeat the mapping I think it would be best to do as HTML-AAM does, and say "See WAI-ARIA mappings", for example: https://w3c.github.io/html-aam/#el-a
- As for the sections in the beginning, rather than duplicate I think it is best to reference when relevant.
Discussed in PDF-AAM Task Force meeting today: Relating to your numbered items above: 1: Daniel has helped remove those. Thanks Daniel! 2: I will work on getting my export script updated to add 'class="data"' to all the tables
Then in general as discussed on the call, this import's main intent was to build the template/framework for all of the tables. Fill out the structure to start opening issues against in the PDF-AAM repo and future PRs will be much more concise. As we are also trying to move from our spreadsheet into doing this work here on GitHub, having the base structure built out enables us to more effectively decouple from the old worksheet.
In general, the TODOs were left to be flags so we could in fact reference "See WAI-ARIA mappings" either HTML-AAM or Core-AAM as the situation dictates. I am still unclear of how to properly do that reference, or in general best ways to reference re-spec tasks. But I expect that to be done in its own PR.
4: Agreed.
I reduced the initial import to just 11 tables. However, I still need more guidance on what to use for the h4 id, and the aria-labelledby attributes.
@cookiecrook & @daniel-montalvo My most recent commit attempts to apply the advice you all listed here. You will notice that we likely still need to figure out better id names for the link structure elements. Also, the last entry, "attribute" definitely needs to be changed/updated, I'm just not sure of the best way to do this. I will discuss it today with @PaulRayius in our PDFa meeting.
Thanks @spectranaut for your comments. @zakkinsey is the prose something some in your team can have a look at or you require some help with that?
Yes, thank you @spectranaut! @daniel-montalvo we will take a first pass at this and if we run into anything we don't think we can handle we will reach out. I suspect we will lean towards removing sections we are unsure of for now and adding them back in later as our focus shifts to less on the AAM table mapping entries to more on these sections. Again, thanks for all the help and guidance through this process for us!
Remaining feedback raised as new issues on PDF-AAM.