aria icon indicating copy to clipboard operation
aria copied to clipboard

Add `class` and `id` mappings

Open smockle opened this issue 1 year ago • 5 comments
trafficstars

Closes https://github.com/w3c/html-aam/issues/553

Initially filed as https://github.com/w3c/html-aam/pull/559

@aleventhal provided mappings in https://github.com/w3c/html-aam/issues/553. I verified they match up with Chromium’s mappings:

id

class

Reviewers: Please also check the formatting. I’ve attempted to match existing styles, but those are inconsistent, e.g. “Object attributes” is bold in datetime (but not in draggable); it uses <code> in src (but not in abbr).

Previews

Test, Documentation and Implementation tracking Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
  • [ ] "author MUST" tests:
  • [ ] "user agent MUST" tests:
  • [ ] Browser implementations (link to issue or commit):
  • [ ] Does this need AT implementations?
  • [ ] Related APG Issue/PR:
  • [ ] MDN Issue/PR:

smockle avatar Aug 08 '24 16:08 smockle

Deploy Preview for wai-aria ready!

Name Link
Latest commit d9b8df6962f6b6fef790af12893129f057c66f1f
Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66c340099959cd0008bd700a
Deploy Preview https://deploy-preview-2308--wai-aria.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 08 '24 16:08 netlify[bot]

Removing myself as reviewer as I just wanted to review the code references.

rahimabdi avatar Aug 12 '24 00:08 rahimabdi

Ok, I checked Firefox, and Firefox doesn't implement AXDOMClassList on, but otherwise is good. I think webkit implements both so this is good to land after three positive reviews :)

spectranaut avatar Aug 12 '24 23:08 spectranaut

approving pending @rahimabdi's review to just verify the webkit mappings.

once good on that, we can merge.

scottaohara avatar Aug 19 '24 12:08 scottaohara

@smockle @spectranaut @scottaohara The WebKit mappings are correct:

rahimabdi avatar Sep 19 '24 21:09 rahimabdi