aria
aria copied to clipboard
Add `class` and `id` mappings
Closes https://github.com/w3c/html-aam/issues/553
Initially filed as https://github.com/w3c/html-aam/pull/559
@aleventhal provided mappings in https://github.com/w3c/html-aam/issues/553. I verified they match up with Chromium’s mappings:
id
kHtmlIdmaps toidin ax_platform_node_base.cc;l=1506-1509kHtmlIdmaps toUIA_AutomationIdPropertyIdin ax_platform_node_win.cc;l=5254-5264 (viaGetAuthorUniqueId())kHtmlIdmaps toAXDOMIdentifierin ax_platform_node_cocoa.mm;l=1594-1601
class
kClassNamemaps toclassin ax_platform_node_base.cc;l=1492-1497kClassNamemaps toUIA_ClassNamePropertyIdin ax_platform_node_win.cc;l=5265-5269kClassNamemaps toAXDOMClassListin ax_platform_node_cocoa.mm;l=1577-1592
Reviewers: Please also check the formatting. I’ve attempted to match existing styles, but those are inconsistent, e.g. “Object attributes” is bold in datetime (but not in draggable); it uses <code> in src (but not in abbr).
Previews
❧
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.- [ ] "author MUST" tests:
- [ ] "user agent MUST" tests:
- [ ] Browser implementations (link to issue or commit):
- WebKit:
- Gecko: Bug for AXDOMClassList on Webkit
- Blink: current implementation
- [ ] Does this need AT implementations?
- [ ] Related APG Issue/PR:
- [ ] MDN Issue/PR:
Deploy Preview for wai-aria ready!
| Name | Link |
|---|---|
| Latest commit | d9b8df6962f6b6fef790af12893129f057c66f1f |
| Latest deploy log | https://app.netlify.com/sites/wai-aria/deploys/66c340099959cd0008bd700a |
| Deploy Preview | https://deploy-preview-2308--wai-aria.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Removing myself as reviewer as I just wanted to review the code references.
Ok, I checked Firefox, and Firefox doesn't implement AXDOMClassList on, but otherwise is good. I think webkit implements both so this is good to land after three positive reviews :)
approving pending @rahimabdi's review to just verify the webkit mappings.
once good on that, we can merge.
@smockle @spectranaut @scottaohara The WebKit mappings are correct: