aria icon indicating copy to clipboard operation
aria copied to clipboard

Editorial: Make specURLs consistent and fix some respec warnings

Open daniel-montalvo opened this issue 1 year ago • 2 comments


Preview | Diff

daniel-montalvo avatar Aug 06 '24 16:08 daniel-montalvo

Deploy Preview for wai-aria ready!

Name Link
Latest commit 9c6d6a8a5624051559e1077025ed0c2df288fb24
Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67aca5ebbb44120008154d47
Deploy Preview https://deploy-preview-2305--wai-aria.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 06 '24 16:08 netlify[bot]

Hi @spectranaut

        <div data-include="https://rawgit.com/w3c/aria/master/../common/acknowledgements/funders.html" data-include-replace="true"></div>

I think we should replace it with common/acknowledgements/funders.html, not sure why it's using the absolute path here, plus it throws a 404, at least when running respec on the browser.

I've replaced it here, left https://github.com/w3c/aria/pull/2288/files#diff-5c3c8936e81538898c83ae11f5271e9ae9324925713a3b03aca58cbd2a3c3014 intact.

daniel-montalvo avatar Aug 20 '24 12:08 daniel-montalvo

@daniel-montalvo is this still relevant? If so, could you update it to resolve the merge conflicts?

pkra avatar Jan 29 '25 10:01 pkra

Thanks @pkra for having a look at this.

Resolved conflicts.

I'd like to take a closer look at this to see if is actually worth merging.

I'll put this as draft for now and change it back when I'm done.

Best.

daniel-montalvo avatar Jan 29 '25 12:01 daniel-montalvo

@daniel-montalvo this is marked as a draft. Is this ready?

pkra avatar Feb 09 '25 18:02 pkra

Couldn’t get to this yet, sorry.

--

Daniel Montalvo Charameli

Accessibility Specialist

W3C/WAI

From: Peter Krautzberger @.> Sent: Sunday, February 9, 2025 7:09 PM To: w3c/aria @.> Cc: Daniel Montalvo @.>; Mention @.> Subject: Re: [w3c/aria] Editorial: Make specURLs consistent and fix some respec warnings (PR #2305)

@daniel-montalvo https://github.com/daniel-montalvo this is marked as a draft. Is this ready?

— Reply to this email directly, view it on GitHub https://github.com/w3c/aria/pull/2305#issuecomment-2646443356 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYFOWUL6P67X2FZLFGFGBL2O6KSXAVCNFSM6AAAAABMCWK2WOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWGQ2DGMZVGY . You are receiving this because you were mentioned.Message ID: @.***>

daniel-montalvo avatar Feb 11 '25 13:02 daniel-montalvo

Should be ready now.

+1 to @pkra 's suggestion. Also, a future project would be to try to put respec config in separate files (different than the index.html) for easier maintenance.

daniel-montalvo avatar Feb 12 '25 15:02 daniel-montalvo

@daniel-montalvo the following two merge actions failed - could you take a look?

https://github.com/w3c/aria/actions/runs/13290698310, https://github.com/w3c/aria/actions/runs/13290698329

pkra avatar Feb 12 '25 20:02 pkra