aria-practices icon indicating copy to clipboard operation
aria-practices copied to clipboard

Infrastructure: Group Minor/Patch Dependabot updates

Open nschonni opened this issue 1 year ago • 4 comments

Not sure how the commit message/PR title will show up for this one. The idea is that all the minor patch updates will be in one PR, but the major version updates will continue to be opened as individual PRs

nschonni avatar Jul 28 '24 19:07 nschonni

but figuring out what's changed and pulling that bump into its own PR shouldn't be an issue based on how the grouped PR is presented

Looking again at the grouped PR, change notes on lint-staged, prettier and selenium-webdriver were left off at the end. Unsure why.

howard-e avatar Jul 31 '24 15:07 howard-e

I wonder if there is also a review benefit in grouping together like dependencies which already need (at times) to move forward together, such as eslint*, stylelint*, but also require some code modification at times. Being able to view that isolated but 'grouped' change could be useful but I don't feel strongly. Any thoughts on that?

Yeah, that might be cleaner, but since the update PRs here aren't usually as urgent to review and land, as with an app, I think it's fine to keep them as the big lump 😄

nschonni avatar Jul 31 '24 18:07 nschonni

Looking again at the grouped PR, change notes on lint-staged, prettier and selenium-webdriver were left off at the end. Unsure why.

I wonder if the size of the changelogs might have hit a limit on the API or the bot template

nschonni avatar Jul 31 '24 18:07 nschonni

Looking again at the grouped PR, change notes on lint-staged, prettier and selenium-webdriver were left off at the end. Unsure why.

I wonder if the size of the changelogs might have hit a limit on the API or the bot template

Possibly! I'll check if that's the case

howard-e avatar Aug 14 '24 16:08 howard-e