aria-practices icon indicating copy to clipboard operation
aria-practices copied to clipboard

Published 20 hours ago • verified publisher icon w3c

Infrastructure: Fix syntax highlighting bug on examples

Open evmiguel opened this issue 1 year ago • 2 comments

This PR addresses #2815. I upgraded highlight.js to get the latest features, as we were behind a few major versions.

WAI Preview Link (Last built on Thu, 29 Feb 2024 15:49:24 GMT).

evmiguel avatar Feb 29 '24 15:02 evmiguel

@alflennik The change from <br> to \n was because highlightjs stopped supporting break tags. See https://github.com/highlightjs/highlight.js/issues/3285#issuecomment-885995008

evmiguel avatar Mar 06 '24 16:03 evmiguel

@a11ydoer could you also confirm this resolves the issue as expected?

howard-e avatar Mar 06 '24 16:03 howard-e

The ARIA Authoring Practices (APG) Task Force just discussed Infrastructure: Fix syntax highlighting bug on examples by evmiguel · Pull Request #2939 · w3c/aria-practices.

The full IRC log of that discussion <jugglinmike> subtopic: Infrastructure: Fix syntax highlighting bug on examples by evmiguel · Pull Request #2939 · w3c/aria-practices
<jugglinmike> github: https://github.com/w3c/aria-practices/pull/2939
<jugglinmike> Matt_King: I think this needs a visual review
<jugglinmike> Jem: I will do it

css-meeting-bot avatar Apr 02 '24 18:04 css-meeting-bot