w3c
Unexpected behavior note follow up
This PR encompasses @alflennik's commits with a merge to main and a few other changes. https://github.com/w3c/aria-at/pull/802 must also be merged alongside this change. When this is merged, #450 can be deleted.
Steps to test:
- Run migration
- Open a test run in the Test Queue
- Select, "Yes, there were additional unexpected behaviors." for one of the commands
- Select some checkboxes
- Observe that the explanation text box is enabled
- Try selecting 'Other' and submitting
- Observe that it is required
One important note is that the unexpected behavior note PR for the aria-at repo will also need to be updated. I wouldn't expect as many merge conflicts, which is good. It's important to make sure the test runner is the same to prevent any very confusing issues from popping up.
Thank you for reviving this ancient PR, thinking of the conflicts you probably had to fix makes me sweat! I did notice one issue when testing it, which is the case where I select that "Yes, there were unexpected behaviors" and then fail to specify any of the radio buttons. When I hit submit, the toggle switches from "Yes" to "No", but more importantly the error is not focused or scrolled to, forcing me to look over all the forms trying to find the one that didn't work.
The error is scrolled to and required is shown, when adding inputs in order. As for the toggling, the app is written in such a way that if you submit, "Yes", but there are no radio buttons, the default is set to "No". What is the intended behavior?
@alflennik You should now be able to observe that when you select "Yes" with no unexpected behaviors and submit the form, the page scrolls to the required element and "Yes" is not toggled to "No".