activitystreams icon indicating copy to clipboard operation
activitystreams copied to clipboard

Is there a minor mistake in the Remove example?

Open sfolsom opened this issue 1 year ago • 3 comments

Should this (https://github.com/w3c/activitystreams/blob/54a6723ed1c8b95a12997b4e73100308e267fc8f/test/vocabulary-ex28-jsonld.json#L11) be using the as:origin property rather than as:target?

See: https://github.com/w3c/activitystreams/blob/54a6723ed1c8b95a12997b4e73100308e267fc8f/vocabulary/index.html#L1510.

sfolsom avatar Apr 04 '23 13:04 sfolsom

It seems to be that origin ("from") would be more fitting than target ("to") for the Remove activity, and that example.

Remove object from location.

Add object from location to location. Remove object from location. Delete object from location. Move object from location to location. ...

csarven avatar Apr 04 '23 16:04 csarven

I came here to open exactly this issue. The description text is correct, but the Remove example was probably wrongly copy pasted from the Add example.

pietercolpaert avatar May 08 '23 13:05 pietercolpaert

So, it seems like an error in the example code. The correct resolution is to add an erratum that says "target" should be "origin" in this example.

Unfortunately, ActivityPub defines the Remove activity to use "target". So, we will probably need to recommend that implementers support "origin" by default, and "target" as a fallback, regardless of the unfortunate illogic of it.

evanp avatar Jul 06 '23 14:07 evanp