activitystreams icon indicating copy to clipboard operation
activitystreams copied to clipboard

Fix example 183 lat/lon values to Numbers, not String

Open gobengo opened this issue 7 years ago • 3 comments

Resolves #446

gobengo avatar Jan 24 '18 23:01 gobengo

Shouldn't this have been fixed in the file https://github.com/w3c/activitystreams/blob/master/test/vocabulary-ex183-jsonld.json instead? And the re-gen the php @gobengo ?

kaleb avatar Jan 30 '20 00:01 kaleb

@kaleb I don't believe the index.html is generated from those example json files.

Also have no idea why @evanp closed this. Still seems right to have those be numbers and not strings. All the other uses of the latitude/longitude properties in the vocabulary document use numbers.

gobengo avatar Jan 30 '20 07:01 gobengo

The problem was documented in the errata from what I can see: https://github.com/w3c/activitystreams/commit/3b5df7a12eac0851ebfc50daeefdd51f47f2d919

That said, fixing the main HTML file itself would still make sense I think, so re-opening the pull request (at the very least, documenting why it should be closed would be better)

dontcallmedom avatar Jan 31 '20 07:01 dontcallmedom