activitypub icon indicating copy to clipboard operation
activitypub copied to clipboard

Errata: Misleading note in 5.7 Likes

Open nightpool opened this issue 4 years ago • 1 comments

In 5.7, Likes collection, we have this informative note: (emphasis added)

Note

Care should be taken to not confuse the the likes collection with the similarly named but different liked collection. In sum:

  • liked: Specifically a property of actors. This is a collection of Like activities performed by the actor, added to the collection as a side effect of delivery to the outbox.
  • likes: May be a property of any object. This is a collection of Like activities referencing this object, added to the collection as a side effect of delivery to the inbox.

However, when this note describes the liked collection, it contradicts the normative definition given in 5.5:

Every actor MAY have a liked collection. This is a list of every object from all of the actor’s Like activities, added as a side effect.

Which matches the definition of the side effect of Likes received in the outbox given in 6.8:

The side effect of receiving this in an outbox is that the server SHOULD add the object to the actor's liked Collection.

Essentially, 5.5 and 6.8 consistently describe the liked collection as containing Objects, while a non-normative note in 5.7 describes the liked collection as containing Activities pointing to the liked objects. This has already caused some confusion.. We should publish an errata stating something like the following:

In section 5.7, a non-normative note describes the liked collection as containing Like activities. In fact, the liked collections contains all of the objects that the actor has Liked, as specified by sections 5.5 and 6.8. The note should be updated to read as follows (changes bolded):

Note

Care should be taken to not confuse the the likes collection with the similarly named but different liked collection. In sum:

  • liked: Specifically a property of actors. This is a collection of all objects from the actor's Like activities, added to the collection as a side effect of delivery to the outbox.
  • likes: May be a property of any object. This is a collection of Like activities referencing this object, added to the collection as a side effect of delivery to the inbox.

Thanks to @wmurphyrd for pointing this out on the SocialHub forums!

nightpool avatar May 01 '20 11:05 nightpool

This is a dupe of #317

cjslep avatar May 06 '20 09:05 cjslep

This is a duplicate of #317 as @cjslep points out. However, it has a better analysis, so it's worth reading on its own. I'm going to close this in favour of the earlier issue.

evanp avatar May 24 '24 16:05 evanp