rison-node icon indicating copy to clipboard operation
rison-node copied to clipboard

Published 20 hours ago • verified publisher icon w33ble

Provide TypeScript definitions

Open legrego opened this issue 6 years ago • 4 comments

Adding TS definitions would help with type safety

legrego avatar Oct 10 '18 14:10 legrego

Is this what would need to be added? https://www.npmjs.com/package/@types/rison https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/rison

fabio-looker avatar Oct 19 '18 02:10 fabio-looker

Yep, I think those typedefs would end up working for this. We'd just need to re-publish under @types/rison-node, or include those typedefs directly in this repository. I prefer the latter approach, as it's one less dependency to maintain in downstream projects

legrego avatar Oct 19 '18 18:10 legrego

I'm also in favor of pulling types into this repo, less dependencies and also easier to keep things in sync.

w33ble avatar Oct 19 '18 22:10 w33ble

Btw decode_uri is not in the linked typedefs since it is specific to rison-node.

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/761c11c125ae9acf6d9450959f13c01bb1c3e6f1/types/rison/index.d.ts#L32-L36

tiffon avatar Nov 22 '21 10:11 tiffon