ispconfig3_roundcube icon indicating copy to clipboard operation
ispconfig3_roundcube copied to clipboard

Published 20 hours ago • verified publisher icon w2c

Add fields for purge_junk_days and purge_trash_days

Open helmo opened this issue 3 years ago • 6 comments

This was added in ISPconfig 3.2

Selection_262

helmo avatar Nov 13 '20 14:11 helmo

@thompol could you review this?

helmo avatar Nov 19 '20 08:11 helmo

@helmo Gladly. It looks good to me, I suppose you tested it?

thompol avatar Nov 19 '20 09:11 thompol

Sure. It seems to work here, but an extra test is always good ;)

helmo avatar Nov 19 '20 10:11 helmo

I have some notes, though I am not responsible for this project :)

  • Maybe these settings should be under filter and not spam, like it is in the ISPConfig UI?
  • The fields are not added to the templates, at least not for elastic, so the fields don't show up in Roundcube. Did you miss committing the files for this?

thompol avatar Nov 20 '20 15:11 thompol

  • Moving to the filters page doesn't seem like a perfect fit either ... maybe general?

  • I didn't have to change any template, thge field is added in ispconfig3_spam/ispconfig3_spam.php

... just tried elastic I also see the fields there.

helmo avatar Nov 20 '20 15:11 helmo

Could be in general aswell, but in the ISPConfig UI it's in filters.

My bad, this test system's Roundcube installation is a mess. Fixed it now. Works fine.

thompol avatar Nov 20 '20 15:11 thompol