Tydux icon indicating copy to clipboard operation
Tydux copied to clipboard

Define redux-devtools-extension as dependency or peerDependency

Open pburgmer opened this issue 4 years ago • 3 comments

Tydux uses redux-devtools-extension, e.g. in store.ts. But it neither declares it as dependency or peerDependency. As of redux itself is declared as peerDependency I would suggest to declare redux-devtools-extension also as peerDependency.

pburgmer avatar Jul 28 '20 08:07 pburgmer

In the actual package.json this package is reverenced as a dependency as follows "redux-devtools-extension": "2.13.8". Should we close this issue or move it to peer-dependencies?

sengmann avatar Oct 27 '20 07:10 sengmann

I'm still pro dev-dependency.

pburgmer avatar Nov 02 '20 22:11 pburgmer

The advantage of peerDependencies that we could declare the dependency but the user could still choose the version, correct? So this should apply to the redux dependency.

The redux-devtools-extension should be listed as devDependency, or shouldn't it?

romanroe avatar Nov 03 '20 06:11 romanroe