vyzo

Results 643 comments of vyzo

sure, but it needs to be cleared, otherwise its memroy leak and dos waiting to happen. Or at best the feature breaks itself for long running nodes. I suggest for...

Sure, we can add it to `IDENTIFY`.

we do have unix socket based ips, that's for identifying the actual ipc protocol version.

We recently introduced default validators with an implementation that rejects old sequence numbers. It can be improved (planned follow up to use a sack bitfield for tracking the last 64...

yeah, not binding. I am not dead set on removing them either.

Quite a few things have changed, but the only important change in behaviour is in #76.

Yes, it will take a heartbeat for the new peer to get grafted, which is by default 1s.

Well, `ListPeers` returns all the known peers that speak the same pubsub protocol(s) as us. It would be a breaking change in behavior to only return peers in the mesh...

Actually, the delay has been fixed in v0.3.0: https://github.com/libp2p/go-libp2p-pubsub/blob/master/gossipsub.go#L952 So when we join, we immediately graft some peers.

Actually, if you enable flood publishing in gsv1.1 (`WithFloodPublish` option), all the direct peers and not just the ones in the mesh will receive any messages you publish (modulo dropped...