nova-permission icon indicating copy to clipboard operation
nova-permission copied to clipboard

Role and Permission name validation

Open ale1981 opened this issue 4 years ago • 1 comments

The validation on the Role and Permission name field is wrong, you can have a Role or Permission with the same name but not the same name and guard, so I believe...

            Text::make(__('nova-permission-tool::roles.name'), 'name')
                ->rules(['required', 'string', 'max:255'])
                ->creationRules('unique:'.config('permission.table_names.roles'))
                ->updateRules('unique:'.config('permission.table_names.roles').',name,{{resourceId}}'),

should be ...


            Text::make(__('nova-permission-tool::roles.name'), 'name')
                ->rules(['required', 'string', 'max:255'])
                ->creationRules('unique:'.config('permission.table_names.roles').',name,,,guard_name,'.$request->guard_name)
                ->updateRules('unique:'.config('permission.table_names.roles').',name,{{resourceId}},id,guard_name,'.$request->guard_name),

ale1981 avatar Nov 22 '20 19:11 ale1981

+1 This is a problem when you have two guards and the same permission name.

FrancoFourmantin avatar Aug 25 '21 19:08 FrancoFourmantin