vyper icon indicating copy to clipboard operation
vyper copied to clipboard

fix: search path for json input

Open charles-cooper opened this issue 11 months ago • 2 comments

What I did

fix for ape-vyper -- apparently, vvm is being called with -p /home/a/b/c/my_project/contracts/, and then the source filename in the json input is foo.vy.

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

charles-cooper avatar Mar 02 '24 16:03 charles-cooper

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (b4429cf) to head (528f312). Report is 164 commits behind head on master.

Files Patch % Lines
vyper/cli/vyper_json.py 0.00% 4 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (b4429cf) and HEAD (528f312). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (b4429cf) HEAD (528f312)
68 61
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3828       +/-   ##
===========================================
- Coverage   85.19%   68.76%   -16.43%     
===========================================
  Files          92       92               
  Lines       13916    13919        +3     
  Branches     3118     3119        +1     
===========================================
- Hits        11856     9572     -2284     
- Misses       1565     3629     +2064     
- Partials      495      718      +223     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 02 '24 17:03 codecov-commenter

i'm actually removing the -p option for json input in https://github.com/vyperlang/vyper/pull/3891, there will be a search_paths option though

charles-cooper avatar Apr 30 '24 15:04 charles-cooper

closing since #3891 gets rid of the -p option for standard json input

charles-cooper avatar May 17 '24 17:05 charles-cooper