vyper icon indicating copy to clipboard operation
vyper copied to clipboard

feat[lang]: introduce `mana` as an alias for `gas`

Open pcaversaccio opened this issue 2 years ago • 3 comments

What I did

In light of EIP-6789, I introduce mana as an alias for gas. Since mana is so far only an alias, I do deliberately not replace all the gas kwargs nor any other gas keywords in the documentation with mana.

How I did it

I introduce a new transaction property called msg.mana that is semantically the same as msg.gas.

How to verify it

Commit message

feat: introduce `mana` as an alias for `gas`

Description for the changelog

Introduce mana as an alias for gas.

Cute Animal Picture

image

pcaversaccio avatar Dec 28 '23 16:12 pcaversaccio

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.60%. Comparing base (24cfe0b) to head (6ccc25a).

:exclamation: Current head 6ccc25a differs from pull request most recent head 162c444

Please upload reports for the commit 162c444 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
- Coverage   91.26%   88.60%   -2.66%     
==========================================
  Files         109      106       -3     
  Lines       15552    15288     -264     
  Branches     3417     3367      -50     
==========================================
- Hits        14193    13546     -647     
- Misses        929     1230     +301     
- Partials      430      512      +82     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 28 '23 16:12 codecov-commenter

interesting PR, i need to meditate on this one!

charles-cooper avatar Dec 28 '23 17:12 charles-cooper

note that after EOF, there won't be any references to gas within the EVM, so there may not be anything to do here

charles-cooper avatar May 16 '24 14:05 charles-cooper