vyperlang
feat: default code offset = 3
What I did
Set default code offset for blueprint contracts to 3
How I did it
Just change the default value from zero_value (which is IRnode.from_list(0, typ=UINT256_T)) to IRnode.from_list(3, typ=UINT256_T).
How to verify it
Added a test that simply uses no code_offset for initcode with the EIP5202 magic val appended at the top
Commit message
Sets default code offset to 3 (instead of 0).
Description for the changelog
Update: Sets default code offset to 3 (instead of 0).
Cute Animal Picture
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7bdebbf) 84.93% compared to head (bea6a63) 84.89%. Report is 14 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
- Coverage 84.93% 84.89% -0.05%
==========================================
Files 92 92
Lines 13685 13734 +49
Branches 3074 3078 +4
==========================================
+ Hits 11623 11659 +36
- Misses 1572 1586 +14
+ Partials 490 489 -1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
alright i fixed the tests and updated the docs. since this is a breaking change (and we don't really want to break user code with 'patch' changes), going to hold off on this until the 0.4.0 series.
also i'm not a huge fan of the duplicated code in the new test case - it would be nice to think of a way around that.
i fixed the merge conflicts and updated the test so it passes. @pcaversaccio @fubuloubu want to take a look in case i missed anything?