vyper icon indicating copy to clipboard operation
vyper copied to clipboard

chore: refactor eth_abi encode_single and decode_single

Open bout3fiddy opened this issue 3 years ago • 1 comments

What I did

following: https://github.com/ethereum/eth-abi/issues/84

encode_single and decode_single are deprecated in favor of encode and decode. So just replaced it.

How I did it

Just replace the signatures

How to verify it

check eth_abi issue, run tests as normal (since eth_abi was mostly used in tests).

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

chore: refactor eth_abi encode_single and decode_single calls

Description for the changelog

Refactored code calling encode_single and decode_single, since: https://github.com/ethereum/eth-abi/issues/84

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

bout3fiddy avatar Sep 17 '22 08:09 bout3fiddy

looks like this causes some test failures. also since the function names being imported are a bit common ("encode" and "decode") i would prefer if they were namespaced. so maybe import eth_abi as abi instead of from eth_abi import...

charles-cooper avatar Sep 17 '22 16:09 charles-cooper

closing as stale + unresolved merge conflicts + unresolved test failures

charles-cooper avatar Nov 07 '23 23:11 charles-cooper

I think also superseded by https://github.com/vyperlang/vyper/pull/3326

charles-cooper avatar Nov 07 '23 23:11 charles-cooper