vyper icon indicating copy to clipboard operation
vyper copied to clipboard

Published 20 hours ago • verified publisher icon vyperlang

In ERC721 token standard EIP, onERC721Received isn't annotated as view type

Open rmurray2 opened this issue 2 years ago • 1 comments

  • vyper Version (output of vyper --version): 0.3.4+commit.f31f0ec
  • OS: linux
  • Python Version (output of python --version): 3.8.3

The ERC721 example token standard in examples/tokens/ERC721.vy has an interface, ERC721Receiver, with a function, onERC721Received, that is annotated with view, but in the ERC721 token standard EIP, onERC721Received is not annotated with view

rmurray2 avatar Aug 13 '22 17:08 rmurray2

This is indeed a bug, this should be a state-modifying callback to the receiver. Would you mind creating a PR?

fubuloubu avatar Aug 15 '22 15:08 fubuloubu

fixed here

rmurray2 avatar Nov 04 '22 10:11 rmurray2