vyper icon indicating copy to clipboard operation
vyper copied to clipboard

feat: add pop with index for dynamic arrays

Open tserg opened this issue 2 years ago • 1 comments

What I did

WIP

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

tserg avatar Jul 03 '22 08:07 tserg

Codecov Report

Merging #2948 (f88d978) into master (a6c8e5f) will decrease coverage by 21.37%. The diff coverage is 61.11%.

@@             Coverage Diff             @@
##           master    #2948       +/-   ##
===========================================
- Coverage   88.30%   66.92%   -21.38%     
===========================================
  Files          97       97               
  Lines       10773    10836       +63     
  Branches     2566     2503       -63     
===========================================
- Hits         9513     7252     -2261     
- Misses        802     2937     +2135     
- Partials      458      647      +189     
Impacted Files Coverage Δ
vyper/codegen/expr.py 62.75% <0.00%> (-21.62%) :arrow_down:
vyper/codegen/core.py 70.32% <18.18%> (-14.56%) :arrow_down:
vyper/semantics/validation/annotation.py 80.21% <33.33%> (-9.47%) :arrow_down:
vyper/builtin_functions/functions.py 61.84% <48.38%> (-29.47%) :arrow_down:
vyper/semantics/types/function.py 66.42% <66.66%> (-20.70%) :arrow_down:
vyper/codegen/stmt.py 78.66% <71.42%> (-9.51%) :arrow_down:
vyper/compiler/phases.py 87.50% <90.00%> (-7.42%) :arrow_down:
vyper/codegen/arithmetic.py 41.46% <100.00%> (-33.85%) :arrow_down:
vyper/codegen/ir_node.py 91.00% <100.00%> (-1.31%) :arrow_down:
vyper/codegen/module.py 89.71% <100.00%> (-4.68%) :arrow_down:
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6c8e5f...f88d978. Read the comment docs.

codecov-commenter avatar Jul 03 '22 08:07 codecov-commenter