vyperlang
PyPi package lacks ./tests/conftest.py
Environment information
vvmVersion: 0.2.1vyperVersion: any- Python Version: any
- OS: osx/linux/win
What was wrong?
If the package was downloaded from PyPi then it cannot pass the tests due to lack of ./tests/conftest.py.
How can it be fixed?
It can be fixed by including ./tests/conftest.py file in the PyPi tarball. Cound you please include it starting from the next release?
hmm, it's not really common for production tarballs to include the test suite. is it an issue to pull from the github repo to run the tests?
hmm, it's not really common for production tarballs to include the test suite.
I believe it's the other way around. Most of the dependencies of a various crypto-libraries have test-suite published within their PyPi-tarballs. Even if it were true then perhaps you would remove all the tests from PyPi package since they are not useful. :)
is it an issue to pull from the github repo to run the tests?
No, not a big deal. Right now I am using GitHub tarball and back then I was using PyPi one I've just uploaded the ./tests/conftest.py file during my CI-testing.
Even if it were true then perhaps you would remove all the tests from PyPi package since they are not useful. :)
~hmm i see what you are saying. but actually i see that tests/conftest.py is indeed in the source tarball? https://pypi.org/project/vyper/0.4.0/#files~
oops, wrong project!
yea, it's a bit weird that it's not being included. i would think it's an issue with setup.py, but i tinkered with it for a few minutes and was not able to convince it to include conftest.py in the build. @lemenkov if you find a solution to this, please open a PR!