titanoboa icon indicating copy to clipboard operation
titanoboa copied to clipboard

gnosis safe implementation

Open charles-cooper opened this issue 1 year ago • 6 comments

cf. https://pypi.org/project/ape-safe/ https://github.com/banteg/brownie-safe#readme

charles-cooper avatar Jan 17 '24 15:01 charles-cooper

brownie-safe has call traces in their preview methods, which i think is out of scope in this particular case.

Also, there are implementations to sign with trezor or frame or ledger etc. whereas i think we should simply stick to browsersigner in this case. let users use notebooks to sign transactions, post them, fetch status on pending transactions, execute transactions etc.

bout3fiddy avatar Jan 30 '24 12:01 bout3fiddy

The other issue I see with this is: if we integrate safe into boa, we would need to import web3py and that's going to bloat boa.

bout3fiddy avatar Jan 31 '24 11:01 bout3fiddy

The other issue I see with this is: if we integrate safe into boa, we would need to import web3py and that's going to bloat boa.

i don't see why that would be the case. besides, it should probably be a separate package anyways.

charles-cooper avatar Jan 31 '24 13:01 charles-cooper

https://safe-transaction-mainnet.safe.global/

DanielSchiavini avatar May 06 '24 09:05 DanielSchiavini

The api I recommend is:

with boa.safe.build_transaction():
    coin.approve(safe, 2**256-1)
    safe.spend(coin, 10**18)
    coin.approve(safe, 0)

bout3fiddy avatar May 06 '24 09:05 bout3fiddy

is this issue ready?

DanielSchiavini avatar Jun 03 '24 11:06 DanielSchiavini