titanoboa icon indicating copy to clipboard operation
titanoboa copied to clipboard

boa.test address strategy is not aligned with boa.env.generate_address()

Open bout3fiddy opened this issue 1 year ago • 4 comments

how boa.test generates addresses: https://github.com/vyperlang/titanoboa/blob/f879b3d35c1fb980aa61d18256a8638eb5b952c9/boa/test/strategies.py#L101

how boa.env generates addresses: https://github.com/vyperlang/titanoboa/blob/f879b3d35c1fb980aa61d18256a8638eb5b952c9/boa/environment.py#L579

unify these.

bout3fiddy avatar Dec 21 '23 05:12 bout3fiddy

Hey @bout3fiddy, can I work on this issue?

MukulKolpe avatar Dec 21 '23 09:12 MukulKolpe

Hey @bout3fiddy, can I work on this issue?

go for it

charles-cooper avatar Dec 21 '23 17:12 charles-cooper

what's the issue here? boa.env.generate_address() is kind of deterministic

charles-cooper avatar May 11 '24 12:05 charles-cooper

if this is by design, can we close the issue?

DanielSchiavini avatar Jun 03 '24 11:06 DanielSchiavini

fixed, as of b6eacad8 the address strategy returns Address type

charles-cooper avatar Jul 09 '24 13:07 charles-cooper