vyos-build icon indicating copy to clipboard operation
vyos-build copied to clipboard

vyos-build: T7300: add dependencies for libpam-radius-auth

Open runleveldev opened this issue 7 months ago • 3 comments

Change summary

Adds three packages (libpam0g-de, libaudit-dev, and libcap-dev) needed to build the libpam-radius-auth package from https://github.com/vyos/libpam-radius-auth.

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes)
  • [ ] Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • [ ] Other (please describe):

Related Task(s)

https://vyos.dev/T7300 Discovered while working on https://vyos.dev/T7285

Related PR(s)

Checklist:

  • [x] I have read the CONTRIBUTING document
  • [x] I have linked this PR to one or more Phabricator Task(s)
  • [x] My commit headlines contain a valid Task id
  • [ ] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly

runleveldev avatar Mar 31 '25 15:03 runleveldev

👍 No issues in PR Title / Commit Title

github-actions[bot] avatar Mar 31 '25 15:03 github-actions[bot]

Dependencies for the package build should be here

https://github.com/vyos/vyos-build/blob/c678188cdad6e7907c901a1030e412ba730660ce/scripts/package-build/libpam-radius-auth/package.toml#L6-L10

I'm not sure that this is referenced in the docuementation. As specified in the linked phabricator issue, I was following the documentation from https://docs.vyos.io/en/latest/contributing/build-vyos.html#build-packages which specifies that you should just be able to run the dpkg-buildpackage command.

That being said, if the correct way to do this is with the build.py scripts, I still get this error in the container when running the script.

image

I can add that extra dependency to this PR, but we may want to also consider updating the relevant documentation with reference to the build.py script.

runleveldev avatar Apr 11 '25 19:04 runleveldev

That being said, if the correct way to do this is with the build.py scripts, I still get this error in the container when running the script.

image

How do you build the packages?

I do use the current docker image and after changing into /vyos/scripts/package-build/libpam-radius-auth run ./build.py and it compiles fine (the documentation needs updating indeed).

For me it's the packages libcap-ng-dev and libcap-dev that are installed as dependencies of libaudit-dev as it seems and they are installed when running ./build.py

before:

$ apt list --installed 2>/dev/null | grep 'libcap.*dev'
<nothing>

running ./build.py:

...
The following NEW packages will be installed:
  libaudit-dev libcap-ng-dev libpam0g-dev
The following additional packages will be installed:
  libcap-dev
...
dpkg-buildpackage: info: full upload; Debian-native package (full source is included)
I: Cleaned up build dependency packages

$ apt list --installed 2>/dev/null | grep 'libcap.*dev'
libcap-dev/stable,now 1:2.66-4 amd64 [installed,automatic]
libcap-ng-dev/stable,now 0.8.3-1+b3 amd64 [installed,automatic]
...

Are these packages not installed?

boretom avatar Apr 13 '25 10:04 boretom

The decision is to actually remove build dependencies from the image when they can be easily handled by build.py, so this PR goes againt that idea. Thanks for the effort, though!

dmbaturin avatar Apr 22 '25 15:04 dmbaturin