vyos-1x icon indicating copy to clipboard operation
vyos-1x copied to clipboard

dhcp6relay: T3596: Replace ISC DHCPv6 relay with wide-dhcp6-relay

Open jack9603301 opened this issue 4 years ago • 8 comments

Change Summary

Replace ISC DHCPv6 relay with wide-dhcp6-relay

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes)
  • [ ] Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • [ ] Other (please describe):

Related Task(s)

  • https://phabricator.vyos.net/T3596

Component(s) name

dhcp6relay

Proposed changes

I plan to use wide-dhcp6-relay to support DHCPv6 relay, which may break the limitation of ISC DHCP on PPPoE interface.

How to test

Since the test topology has not been designed yet, only packet capture test is carried out (to confirm whether DHCPv6 PD request packets are sent)

Checklist:

  • [x] I have read the CONTRIBUTING document
  • [x] I have linked this PR to one or more Phabricator Task(s)
  • [x] I have run the components SMOKETESTS if applicable
  • [x] My commit headlines contain a valid Task id
  • [ ] My change requires a change to the documentation
  • [ ] I have updated the documentation accordingly

jack9603301 avatar Jun 03 '21 10:06 jack9603301

Hi Jack,

I wonder why this is flagged only as refactoring bit you open an entire new CLI tree. I also wo der why this is now under the interface secrion and no longer under service.

Please explain in a more detailed manner.

c-po avatar Jun 04 '21 14:06 c-po

@c-po

In fact, I designed it as fix at the beginning, but I found that it almost needs to modify the existing service logic (I can't reuse the old logic, I need to modify the CLI), so I changed it to refactoring

I also wo der why this is now under the interface secrion and no longer under service.

This is mainly because the configuration structure of the interface is convenient and friendly, and the PD configuration is in the same path. This is just a draft. If necessary, you can change the CLI

Traditionally, only one configuration is needed:

set interfaces ethernet eth0 dhcpv6-option dhcp6relay interface eth1

The above configuration takes eth0 as the upstream and provides services for eth1

jack9603301 avatar Jun 04 '21 14:06 jack9603301

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 13 '21 21:06 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jun 17 '21 19:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 22 '21 23:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 23 '21 18:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 08 '22 11:04 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 01 '22 15:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 23 '23 06:01 github-actions[bot]

We'll need to re-evaluate this in 1.5. Closing for now.

dmbaturin avatar Aug 31 '23 14:08 dmbaturin