cleanrl icon indicating copy to clipboard operation
cleanrl copied to clipboard

Change actor_update_interval to policy_frequency in SAC comment

Open JinayJain opened this issue 10 months ago • 1 comments

Description

The variable actor_update_interval was likely renamed without renaming in the comment.

Types of changes

  • [x] Bug fix
  • [ ] New feature
  • [ ] New algorithm
  • [ ] Documentation

Checklist:

  • [ ] I've read the CONTRIBUTION guide (required).
  • [ ] I have ensured pre-commit run --all-files passes (required).
  • [ ] I have updated the tests accordingly (if applicable).
  • [ ] I have updated the documentation and previewed the changes via mkdocs serve.
    • [ ] I have explained note-worthy implementation details.
    • [ ] I have explained the logged metrics.
    • [ ] I have added links to the original paper and related papers.

If you need to run benchmark experiments for a performance-impacting changes:

  • [ ] I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team.
  • [ ] I have used the benchmark utility to submit the tracked experiments to the openrlbenchmark/cleanrl W&B project, optionally with --capture_video.
  • [ ] I have performed RLops with python -m openrlbenchmark.rlops.
    • For new feature or bug fix:
      • [ ] I have used the RLops utility to understand the performance impact of the changes and confirmed there is no regression.
    • For new algorithm:
      • [ ] I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • [ ] I have added the learning curves generated by the python -m openrlbenchmark.rlops utility to the documentation.
    • [ ] I have added links to the tracked experiments in W&B, generated by python -m openrlbenchmark.rlops ....your_args... --report, to the documentation.

JinayJain avatar Apr 22 '24 00:04 JinayJain

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cleanrl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 0:58am

vercel[bot] avatar Apr 22 '24 00:04 vercel[bot]