vpm icon indicating copy to clipboard operation
vpm copied to clipboard

xml comments break xml parsing

Open velcrome opened this issue 9 years ago • 1 comments

The following vpack will not download ZeroMQ, because of the commented dependency.

It will process nicely without the comment, so I think this is a bug.

<vpack>
  <meta>
    <name>vvvv-ZeroMQ</name>
    <source>https://github.com/velcrome/vvvv-ZeroMQ</source>
    <author>velcrome</author>
    <dependencies>
      <!--dependency>
        <name>vvvv-Message</name>
        <source>vpms://raw.githubusercontent.com/velcrome/vvvv-Message/develop/copy/vvvv-Message.vpack</source>
      </dependency-->
    </dependencies>
  </meta>
  <install>
    Download(
      "https://github.com/velcrome/vvvv-ZeroMQ/releases/download/0.5.1/vvvv-ZeroMQ.zip",
      VPM.TempDir + "\\vvvv-ZeroMQ.zip"
    );
    Extract(VPM.TempDir + "\\vvvv-ZeroMQ.zip", Pack.TempDir + "\\extract");
	  CopyDir(
	    Pack.TempDir + "\\extract",
	    VVVV.Dir + "\\packs\\vvvv-ZeroMQ"
	  );
  </install>
</vpack>

Note that this behaviour is recursive, if there is a similar error in the dependency's vpm

velcrome avatar Nov 26 '16 01:11 velcrome

I just noticed this one now very strange I'm using regular .net xml parser, I thought it takes care of that. will have a look when I find time for it

microdee avatar Dec 23 '16 05:12 microdee