iron-session icon indicating copy to clipboard operation
iron-session copied to clipboard

Updating the project for Next 12 SWR Middleware Compatibility

Open ChrisCates opened this issue 2 years ago • 0 comments

This issue has been in limbo for quite some time now. It's been "allegedly" solved with a "hack" from: https://github.com/vvo/iron-session/issues/419

But, in reality. This doesn't help at all with current releases of Next given that buffer, stream and other native Node.js functions aren't available in SWR middleware. I don't understand why @vvo is claiming that this works with 12.0.4 when it doesn't.

The solution is simple. There are browser native versions of these modules. And, all it takes is to move them over to it.

@vvo, I've seen how your pull request process works. And there's already this PR: https://github.com/vvo/iron-session/pull/510 So I'm not going to bother opening my own.

Do you need money to pick up the PR to completion? This is a pretty valuable project. Just trying to push that PR into completion.

ChrisCates avatar Jul 15 '22 18:07 ChrisCates

Can you accept that PR please?

helloworld9912 avatar Aug 17 '22 20:08 helloworld9912

This is now available in 6.2.0, thanks!

vvo avatar Aug 25 '22 21:08 vvo