netcode.io icon indicating copy to clipboard operation
netcode.io copied to clipboard

Fixed compilation errors and updated dependencies

Open manpat opened this issue 8 years ago • 2 comments

Hey I don't know if you're still actively maintaining this project but I had to make a few changes to get it building on my system and I figured I might as well submit a PR

The version from cargo.io fails to locate clang on my system because of how the version of clang-sys used found clang. In essence, on OSes without a standard 'exe' extension it will match directories named 'clang' as well as binaries - the version I've updated it to has checks to avoid this.

Also there's two hard compilation errors in client.rs which I assume were just uncaught copy-paste errors or something. Simple fix but again, the version on cargo.io doesn't compile without it

manpat avatar Nov 08 '17 15:11 manpat

No, this is largely unmaintained and actually pretty out of date. The latest version was in the forked(networkprotocol/netcode.io) library but was since removed since I didn't have time to maintain it.

You're totally welcome to fork it if you want since I probably won't have time to properly review PRs.

vvanders avatar Nov 09 '17 01:11 vvanders

yeah I noticed it was a bit out of date haha

I've fixed a few more bugs and merged it back with the original project over here https://github.com/Game-Insight/netcode.io/tree/master

I can't see myself picking up the maintenance effort, just leaving this here for future reference :p

manpat avatar Nov 15 '17 01:11 manpat