button honor text alignment

[an146]

Button with image had hardcoded NK_TEXT_CENTERED

[dumblob]

Hi @an146, thanks for your contribution. Could you also change the function signature on other places in the library (especially declaration)? Don't forget to bump version accordingly afterwards :wink:.

Btw. if you're interested in more about alignment in Nuklear in general, refer to https://github.com/vurtun/nuklear/issues/844 (though this your pull is not directly related and I'll merge it after it becomes clean).

[an146]

fixed prototype

[dumblob]

Good. Please also bump the Nuklear version :wink:.

[an146]

bumped in package.json, haven't found anywhere else

[dumblob]

It's just in the changelog. Yeah, could be more visible - feel free to add a paragraph to the main README with contribution instructions along the lines:

a) if changes go to nuklear.h: a.1) make changes in src/... a.2) bump version in src/CHANGELOG and package.json a.3) run src/paq.sh or click in src/Readme.md on Click to generate nuklear.h a.4) make a pull request :wink: b) if changes relate to anything else than nuklear.h, just make a straightforward pull

[an146]

done

[diggit]

functions: nk_draw_symbol and nk_draw_button_text_symbol have text centering hardcoded too. Why not change these too?

Also, how strict is nuklear about preserving API? Eg.function suffix _textalign would add new functions and old one would remain same just calling this one. This way, API would remain compatible...

[dumblob]

nk_draw_symbol is too fine grained IMHO to make it configurable

nk_draw_button_text_symbol could be changed - feel free to make a pull request

Also, how strict is nuklear about preserving API?

Not strict at all when it comes to progress. But we're strict in versioning - API breakage means major version bump.

[diggit]

Any progress/decisions here?

[dumblob]

Please see https://github.com/vurtun/nuklear/pull/913#issuecomment-544426947 .