Sergey Vinogradov

Results 151 comments of Sergey Vinogradov

FYI, we have decided to go ahead with Option 1 for now.

I'll look into a better alternative to `reset-layer`. Since this keyword is computed, its actual value isn't visible in DevTools, which makes it difficult to inspect style inheritance.

Similar issue for LitRenderer specifically: https://github.com/vaadin/flow-components/issues/4963 (also caused by UI.getCurrent)

In our internal discussion, it was suggested that we could improve the DX for existing `UI.getCurrent` instances if a `UI.getCurrentOrThrow` API was introduced on the Flow side. This alternative to...

> So what github issue tracks that problem now? The examples listed in this ticket, except for `LitRenderer` and `ComponentRenderer`, require a UI instance by design, so the issue was...

It turns out there are still a few places where the use of `UI.getCurrent` could be avoided: 1. https://github.com/vaadin/flow-components/blob/34dce396c690793172df3136ca422483eee4774c/vaadin-dialog-flow-parent/vaadin-dialog-flow/src/main/java/com/vaadin/flow/component/dialog/Dialog.java#L1233-L1234 2. https://github.com/vaadin/flow-components/blob/34dce396c690793172df3136ca422483eee4774c/vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java#L613-L614 3. https://github.com/vaadin/flow-components/blob/34dce396c690793172df3136ca422483eee4774c/vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src/main/java/com/vaadin/flow/component/spreadsheet/PopupButton.java#L129-L132 4. https://github.com/vaadin/flow-components/blob/34dce396c690793172df3136ca422483eee4774c/vaadin-flow-components-shared-parent/vaadin-flow-components-base/src/main/java/com/vaadin/flow/component/shared/Tooltip.java#L109-L110 I'm reopening the ticket. @archiecobbs...

I tested the attached app but was unable to reproduce `Cannot read properties of undefined (reading 'getByNodeId')`: https://github.com/user-attachments/assets/8f261b36-6954-4478-988b-ecc2db59f0e0 Unfortunately, the stacktrace alone isn't enough to determine the cause – a...

There is one thing that looks fishy in the mentioned code fragment. It checks if the column is attached to a UI using `column.getUI()` but gets the app id using...

> I learned how to set breakpoints in Chrome though :) Here's where the bug happens. Note that that i = "" which looks suspicious... ? The stacktrace suggests that...

@archiecobbs Thank you for investigating. I discussed with @mshabarov, and the absence of UI in `ComponentRenderer` when using `session.accessSynchronously` looks very much like a Flow bug. Here is a simplified...