vulcan icon indicating copy to clipboard operation
vulcan copied to clipboard

request.RequesURI is empty

Open klizhentas opened this issue 11 years ago • 2 comments

We erase request.RequestURI in favor of Opaque data, but this makes access to URL.Query() impossible as it returns empty results.

klizhentas avatar Sep 18 '14 23:09 klizhentas

@klizhentas Just came here to post this issue, and saw it was put up for discussion a few months ago. Any thoughts on not erasing URL.RawQuery on this line? As you mention, it breaks URL.Query().

https://github.com/mailgun/vulcan/blob/master/location/httploc/httploc.go#L305

marbemac avatar Dec 17 '14 04:12 marbemac

In addition, overwriting URL.Opaque in line 303 of httploc seems to mess with URL.Host (and thus URL.String()). Could be specific to my setup, but printing URL.String() after Opaque is overwritten prints with a blank host.

marbemac avatar Dec 17 '14 06:12 marbemac